feat: TET-904 fix MetricsCard

VirtusLab · Sep 3, 2024 · 5d95422 · 5d95422
1 parent 230c309
commit 5d95422
Show file tree

Hide file tree

Showing 12 changed files with 29 additions and 323 deletions.
diff --git a/src/components/Metrics Card/MetricsCard.props.ts b/src/components/Metrics Card/MetricsCard.props.ts
diff --git a/src/components/Metrics Card/MetricsCard.stories.tsx b/src/components/Metrics Card/MetricsCard.stories.tsx
diff --git a/src/components/Metrics Card/MetricsCard.styles.ts b/src/components/Metrics Card/MetricsCard.styles.ts
diff --git a/src/components/Metrics Card/MetricsCard.test.tsx b/src/components/Metrics Card/MetricsCard.test.tsx
diff --git a/src/components/Metrics Card/MetricsCard.tsx b/src/components/Metrics Card/MetricsCard.tsx
diff --git a/src/components/Metrics Card/index.ts b/src/components/Metrics Card/index.ts
diff --git a/src/components/Metrics Card/stylesBuilder.ts b/src/components/Metrics Card/stylesBuilder.ts
diff --git a/src/components/MetricsCard/MetricsCard.props.ts b/src/components/MetricsCard/MetricsCard.props.ts
@@ -1,11 +1,10 @@
-import { IconPositionType, MetricsCardConfig } from './MetricsCard.styles';
+import { MetricsCardConfig } from './MetricsCard.styles';
 import { InlineMetricsProps } from '../InlineMetrics';
 
-export type TrendType = 'None' | 'Positive' | 'Negative';
+export type IconPositionType = 'Top' | 'Left';
 export type IntentType = 'Neutral' | 'Positive' | 'Negative';
 
 export type MetricsCardProps = {
-  intent?: IntentType;
   iconPosition?: IconPositionType;
   hasTrend?: boolean;
   hasIcon?: boolean;

diff --git a/src/components/MetricsCard/MetricsCard.stories.tsx b/src/components/MetricsCard/MetricsCard.stories.tsx
@@ -31,7 +31,6 @@ type Story = StoryObj<typeof meta>;
 
 export const Default: Story = {
   args: {
-    intent: 'Positive',
     trend: 'Positive',
     trendValue: '+24%',
     metrics: '$123.12',
@@ -45,9 +44,8 @@ export const Default: Story = {
 
 export const IconPositionLeft: Story = {
   args: {
-    intent: 'Negative',
     trend: 'Negative',
-    trendValue: '+24%',
+    trendValue: '-24%',
     metrics: '$123.12',
     label: 'Total Earnings',
     hasIcon: true,

diff --git a/src/components/MetricsCard/MetricsCard.styles.ts b/src/components/MetricsCard/MetricsCard.styles.ts
@@ -1,6 +1,6 @@
-import type { BaseProps } from '@/types/BaseProps';
+import type { IconPositionType } from './MetricsCard.props';
 
-export type IconPositionType = 'Top' | 'Left';
+import type { BaseProps } from '@/types/BaseProps';
 
 export type MetricsCardConfig = {
   iconPosition?: Record<IconPositionType, BaseProps>;

diff --git a/src/components/MetricsCard/MetricsCard.tsx b/src/components/MetricsCard/MetricsCard.tsx
@@ -12,7 +12,7 @@ import { tet } from '@/tetrisly';
 export const MetricsCard: FC<MetricsCardProps & MarginProps> = ({
   hasIcon = false,
   hasMoreIcon = false,
-  hasTrend = false,
+  hasTrend,
   metrics,
   label,
   trend = 'None',