-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TET-853 add FileItem component #143
Conversation
src/components/FileItem/components/CompressedVariant/CompressedVariant.props.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! It needs only few small things to do :)
If you style container of
In that case there is no need to add |
Initially I thought about it and I was hesitant against overengineering but definitely it ensures accuracy so I introduced it :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊
What did you implement?
FileUploader component has been implemented. This is one of building blocks of more complex component: FileUploader
because of our width limitation to 888px.
CompressedVariant
andExtendedVariant
. I discovered that compressed version of FileItem:20-file
) instead of icon from Figma:Fallback
inside our*.props.ts
file and create a constant where all possible fallbacks are hardcoded is a good practice and can be imported in component file, styles builder etc. without need for duplication of our default values.How it might be Tested?
Run storybook
Checklist: