fix: when markline date less then minDate should not show #2689

VisActor · Nov 1, 2024 · e93e0ed · e93e0ed
1 parent b0be669
commit e93e0ed
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/assets/guide/en/Contribution_Guide.md b/docs/assets/guide/en/Contribution_Guide.md
@@ -74,7 +74,7 @@ git checkout -b docs/add-funnel-demo
 
 - Now we can make changes to the code on the branch.
 - Let's say we've added some code and committed it to the repository.
-- `git commit -a -m "docs: add custom funnel demo and related docs"`. The commit message for VisActor follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification:
+- `git commit -a -m "docs: add custom funnel demo and related docs"  / "fix: solve which problem #xxxx_issue_id" `. The commit message for VisActor follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification:
 
   - `<type>[optional scope]: <description>`.
   - Common `type` include docs (documentation, log changes), feat (new features), fix (bug fixes), refactor (code refactoring), etc. Please choose according to the actual situation.

diff --git a/docs/assets/guide/zh/Contribution_Guide.md b/docs/assets/guide/zh/Contribution_Guide.md
@@ -76,7 +76,7 @@ git checkout -b docs/add-funnel-demo
 
 - 现在我们可以在分支上更改代码了
 - 假设我们已经添加了一些代码，提交到代码库
-- git commit -a -m "docs: add custom funnel demo and related docs" 。VisActor 的 commit 提交信息遵循 [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) 规范
+- `git commit -a -m "docs: add custom funnel demo and related docs" / "fix: solve which problem #xxxx_issue_id"`。VisActor 的 commit 提交信息遵循 [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) 规范
 
   - `<type>[optional scope]: <description>`
   - 其中常用 `type`包括 docs（文档、日志修改）、feat（新功能）、fix（问题修复）、refactor（代码重构）等，请根据实际情况选择。

diff --git a/packages/vtable-gantt/src/scenegraph/mark-line.ts b/packages/vtable-gantt/src/scenegraph/mark-line.ts
@@ -44,7 +44,7 @@ export class MarkLine {
       const minDate = createDateAtMidnight(this._scene._gantt.parsedOptions.minDate);
       const dateX =
         this._scene._gantt.parsedOptions.colWidthPerDay *
-        (Math.ceil(Math.abs(date.getTime() - minDate.getTime()) / (1000 * 60 * 60 * 24)) +
+        (Math.ceil((date.getTime() - minDate.getTime()) / (1000 * 60 * 60 * 24)) +
           (line.position === 'right' ? 1 : line.position === 'middle' ? 0.5 : 0));
       const markLineGroup = new Group({
         pickable: false,