Skip to content

Commit

Permalink
Revert "Fix oppia#4739 Talkback does not read the expected text"
Browse files Browse the repository at this point in the history
  • Loading branch information
Vishwajith-Shettigar authored Jan 14, 2024
1 parent bb69b22 commit 61c72ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import org.oppia.android.app.utility.lifecycle.LifecycleSafeTimerFactory
import org.oppia.android.app.viewmodel.ViewModelProvider
import org.oppia.android.databinding.PinPasswordActivityBinding
import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.util.accessibility.AccessibilityService
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import javax.inject.Inject
Expand All @@ -32,7 +31,6 @@ class PinPasswordActivityPresenter @Inject constructor(
private val viewModelProvider: ViewModelProvider<PinPasswordViewModel>,
private val resourceHandler: AppLanguageResourceHandler
) {
@Inject lateinit var accessibilityService: AccessibilityService
private val pinViewModel by lazy {
getPinPasswordViewModel()
}
Expand Down Expand Up @@ -71,13 +69,7 @@ class PinPasswordActivityPresenter @Inject constructor(
)
}
}

// If the screen reader is off, the EditText will receive focus.
// If the screen reader is on, the EditText won't receive focus.
// This is needed because requesting focus on the EditText when the screen reader is on gives TalkBack priority over other views in the screen, ignoring view hierachy.
if (!accessibilityService.isScreenReaderEnabled())
binding.pinPasswordInputPinEditText.requestFocus()

binding.pinPasswordInputPinEditText.requestFocus()
// [onTextChanged] is a extension function defined at [TextInputEditTextHelper]
binding.pinPasswordInputPinEditText.onTextChanged { pin ->
pin?.let { inputtedPin ->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ import org.oppia.android.testing.threading.TestCoroutineDispatchers
import org.oppia.android.testing.threading.TestDispatcherModule
import org.oppia.android.testing.time.FakeOppiaClockModule
import org.oppia.android.util.accessibility.AccessibilityTestModule
import org.oppia.android.util.accessibility.FakeAccessibilityService
import org.oppia.android.util.caching.AssetModule
import org.oppia.android.util.caching.testing.CachingTestModule
import org.oppia.android.util.gcsresource.GcsResourceModule
Expand Down Expand Up @@ -148,9 +147,6 @@ class PinPasswordActivityTest {
@Inject
lateinit var editTextInputAction: EditTextInputAction

@Inject
lateinit var fakeAccessibilityService: FakeAccessibilityService

private val adminPin = "12345"
private val adminId = 0
private val userId = 1
Expand Down Expand Up @@ -185,8 +181,7 @@ class PinPasswordActivityTest {
}

@Test
fun testPinPassword_withAdmin_screenReaderOff_keyboardIsVisible() {
fakeAccessibilityService.setScreenReaderEnabled(false)
fun testPinPassword_withAdmin_keyboardIsVisibleByDefault() {
ActivityScenario.launch<PinPasswordActivity>(
PinPasswordActivity.createPinPasswordActivityIntent(
context = context,
Expand All @@ -198,20 +193,6 @@ class PinPasswordActivityTest {
}
}

@Test
fun testPinPassword_withAdmin_screenReaderOn_keyboardIsNotVisible() {
fakeAccessibilityService.setScreenReaderEnabled(true)
ActivityScenario.launch<PinPasswordActivity>(
PinPasswordActivity.createPinPasswordActivityIntent(
context = context,
adminPin = adminPin,
profileId = adminId
)
).use {
onView(withId(R.id.pin_password_input_pin_edit_text)).check(matches(not(hasFocus())))
}
}

@Test
fun testPinPassword_withAdmin_inputCorrectPin_opensHomeActivity() {
ActivityScenario.launch<PinPasswordActivity>(
Expand Down

0 comments on commit 61c72ec

Please sign in to comment.