fix(#356): 약관기능 유저 모듈로 이동 및 알림 모듈 생성#358
Open
TAEW00KIM wants to merge 1 commit intoVitaCheck:developfrom
Open
Conversation
Contributor
ParkJiYeoung8297
left a comment
ParkJiYeoung8297
left a comment
There was a problem hiding this comment.
다시 수정 필요 ! merge 안됨 ❌
코멘트 적어둔거 참고해주세요!
| dependencies { | ||
| implementation project(":module-common") | ||
| implementation project(":module-user") | ||
| implementation project(":module-product") |
Contributor
There was a problem hiding this comment.
user, product까지 다 implementation 할거면, 사실상 notification 모듈을 분리하는 의미가 없어요.
모듈 분리라는게, implementation (의존 관계)를 끊어놓으려고 하는 거라,
만약 notification을 분리하고 싶다면, user랑 product는 implementation하지 않는 방법을 찾아야 해요.
그 방법 중 하나가 port-adapter 패턴이에요.
예를 들어 notification이 유저 정보를 가져오고 싶다면, user모듈이 아닌 common모듈에 의존해서 정보를 가져오게 해야해요. (이게 회원이랑 인증 모듈 분리할 때, 말했던 방법!)
Contributor
There was a problem hiding this comment.
모듈을 추가할때, build 폴더는 gitigonre에 추가해서 깃에 올라가지 않게 해주세요!
ParkJiYeoung8297
force-pushed
the
develop
branch
from
b149b6e to
694388c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #356
📝 작업 내용
약관 기능을 유저 모듈로 이동
알림 모듈 생성
✅ 변경 사항
💬 리뷰어에게
알림 기능 테스트 필요