Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CostSurface): Adds GET endpoint to retrieve one and all Cost Surfaces for a Project [MRXN23-108] [MRXN23-109] #1531

Conversation

KevSanchez
Copy link
Collaborator

…faces for a Project

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:31pm

@hotzevzl
Copy link
Member

hotzevzl commented Oct 3, 2023

@KevSanchez only note on this, we're not including the JSON:API metadata section in the response, IIRC because we don't have this "ready-made" by nestjs-base-service, but maybe it's ok like this - this is not a full JSON:API endpoint with pagination and so on, so it can be as simple as possible.

@KevSanchez KevSanchez force-pushed the feature/api/MRXN23-97-delete-cost-surface branch from 3d65805 to 2823402 Compare October 3, 2023 16:26
@KevSanchez KevSanchez force-pushed the feature/api/MRXN23-108-109-get-cost-surfaces branch from e74f167 to ff316ab Compare October 3, 2023 16:27
@hotzevzl hotzevzl merged commit 7c02932 into feature/api/MRXN23-97-delete-cost-surface Oct 4, 2023
@hotzevzl hotzevzl deleted the feature/api/MRXN23-108-109-get-cost-surfaces branch October 4, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants