Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CostSurface): Adds CostSurface data to Scenario GET endpoints [MRXN23-110] #1535

Merged

Conversation

KevSanchez
Copy link
Collaborator

Modifies the Scenarios serializer config to account the possible inclusion of costSurfaces on the GET responses (by using FetchSpecification's include in the GET request)

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:27pm

@KevSanchez KevSanchez force-pushed the feature/api/MRXN23-110-add-cost-surface-to-scenario-gets branch 2 times, most recently from 1b5100c to 53ceba6 Compare October 3, 2023 16:23
Modifies the Scenarios serializer config to account the possible inclusion of costSurfaces on the GET responses (by using FetchSpecification's include in the GET request)
@KevSanchez KevSanchez force-pushed the feature/api/MRXN23-110-add-cost-surface-to-scenario-gets branch from 53ceba6 to dfb0eb2 Compare October 3, 2023 16:24
@hotzevzl hotzevzl merged commit 1c7ec94 into develop Oct 4, 2023
@hotzevzl hotzevzl deleted the feature/api/MRXN23-110-add-cost-surface-to-scenario-gets branch October 4, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants