Skip to content

avoid error on export if no scenario has ever been run [MRXN23-473] #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2023
Merged

avoid error on export if no scenario has ever been run [MRXN23-473] #1537

merged 4 commits into from
Oct 9, 2023

Conversation

hotzevzl
Copy link
Member

@hotzevzl hotzevzl commented Oct 6, 2023

yulia-bel and others added 3 commits October 6, 2023 11:27
@yulia-bel @hotzevzl
Update project cost surfaces exporters and importers
fd83590
@hotzevzl
avoid failing when exporting projects that do not have a project summ…
8175c43 
…ary yet

This could happen if no Marxan scenarios have ever been run within the
project being exported.
@hotzevzl
fix speling
a5233ea
@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 0:02am

@hotzevzl hotzevzl force-pushed the fix/api/MRXN23-473_avoid-error-on-export-if-no-scenario-has-ever-been-run branch from 8c7409b to 8e603c3 Compare October 6, 2023 12:00
@hotzevzl hotzevzl marked this pull request as ready for review October 6, 2023 12:01
yulia-bel
yulia-bel approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@yulia-bel yulia-bel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally by duplicating empty project (no scenarios), all works well

@hotzevzl hotzevzl merged commit 128d051 into develop Oct 9, 2023
@hotzevzl hotzevzl deleted the fix/api/MRXN23-473_avoid-error-on-export-if-no-scenario-has-ever-been-run branch October 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yulia-bel yulia-bel yulia-bel approved these changes

@KevSanchez KevSanchez Awaiting requested review from KevSanchez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzevzl @yulia-bel