Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit correct api events when dealing with cost surface uploads [MRXN23-472] #1538

Conversation

hotzevzl
Copy link
Member

@hotzevzl hotzevzl commented Oct 6, 2023

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 5:02pm

@hotzevzl hotzevzl marked this pull request as ready for review October 6, 2023 16:30
@hotzevzl hotzevzl requested review from alexeh and KevSanchez and removed request for KevSanchez and alexeh October 6, 2023 16:30
@hotzevzl hotzevzl marked this pull request as draft October 6, 2023 16:32
@hotzevzl hotzevzl force-pushed the fix/api/MRXN23-472_emit-correct-api-events-when-dealing-with-cost-surface-uploads+tdd branch from 7c5d172 to 14b3771 Compare October 10, 2023 14:13
@hotzevzl hotzevzl force-pushed the fix/api/MRXN23-472_emit-correct-api-events-when-dealing-with-cost-surface-uploads+tdd branch from 14b3771 to 8c5d174 Compare October 11, 2023 12:13
@hotzevzl hotzevzl force-pushed the fix/api/MRXN23-472_emit-correct-api-events-when-dealing-with-cost-surface-uploads+tdd branch from 8c5d174 to 98e2358 Compare October 16, 2023 08:49
@hotzevzl hotzevzl force-pushed the fix/api/MRXN23-472_emit-correct-api-events-when-dealing-with-cost-surface-uploads+tdd branch from 98e2358 to 9ff72dc Compare October 20, 2023 09:15
@hotzevzl hotzevzl force-pushed the fix/api/MRXN23-472_emit-correct-api-events-when-dealing-with-cost-surface-uploads+tdd branch from 9ff72dc to 6dea853 Compare November 8, 2023 16:59
@hotzevzl
Copy link
Member Author

closing in favour of #1576 (removed pointless test, clean up)

@hotzevzl hotzevzl closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant