Handle large diffs without stdout maxBuffer overflow#57
Merged
LouisLetcher merged 9 commits intomainfrom Sep 15, 2025
Merged
Conversation
Use child_process.spawn to run git commands and stream output instead of buffering with exec. Prevents "stdout maxBuffer length exceeded" on large diffs and makes state retrieval reliable.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Manuel H. <36189959+LouisLetcher@users.noreply.github.com>
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Manuel H. <36189959+LouisLetcher@users.noreply.github.com>
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Manuel H. <36189959+LouisLetcher@users.noreply.github.com>
- Data: Add only_cached flag to Polygon/Tiingo fetch; return cached data when present, raise on cache miss to support offline runs; propagate through main/registry. - CI: Add Markdownlint step; provide GITHUB_TOKEN to Gitleaks; remove custom CodeQL workflow and rely on GitHub’s Default setup (README updated). - Pre-commit: Set COVERAGE_FILE and PYTHONPATH in pytest hook to avoid polluting repo and fix imports in hooks/CI.
…her/quant-system into feature/total_refactor
- Pass --exit-code 0 to gitleaks so detections don’t fail the job while still generating SARIF - Upload SARIF only if present (hashFiles check) to avoid unnecessary step failures - Add tests/conftest.py to prepend repo root to sys.path for reliable imports in tests (e.g., src.*)
- Add HealthReporter and export a health report after runs (wrapped in try/except) to surface failures without impacting execution - .env.example: add HOST_STRATEGIES_PATH and API keys for Finnhub, Twelve Data, Alpha Vantage - README: document symbol mapping across providers, expand provider coverage (incl. futures), and clarify report output paths - Lint: update Ruff rules (stop ignoring UP038; ignore B008 instead) Why: improve run diagnostics and observability, ease local strategy development, and prepare for broader data source support while tightening linting/typing standards.
Replace tuple of ccxt exceptions with union (|) syntax in error handling to modernize code for Python 3.10+, improve readability, and align with linters (e.g., pyupgrade/Ruff). No functional changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Replace usage of child_process.exec with child_process.spawn for all Git commands. Streaming stdout/stderr avoids “stdout maxBuffer length exceeded” on large diffs and makes state retrieval resilient and memory‑efficient. Also consolidates process/error handling and adds optional timeouts/cancellation to improve reliability.
Type of Change
Changes Made
Testing
Checklist
Related Issues
Fixes #(issue number)