Open
Conversation
DedSec256
reviewed
Apr 20, 2022
DedSec256
left a comment
DedSec256
left a comment
There was a problem hiding this comment.
- List.min -- 10/10
- Tree to list -- хорошее решение, однако без хвостовой рекурсии, поэтому 8.5/10
| [<Test>] | ||
| let TestEquivalenceForMinFunctions () = | ||
| let funEqual (list: int list) = | ||
| if List.isEmpty list then true else |
There was a problem hiding this comment.
Кажется, можно задать сид для генерации непустых списков, но и так можно
Comment on lines
+11
to
+14
| match filter value with | ||
| | true -> | ||
| result (value :: acc) | ||
| | false -> result acc |
There was a problem hiding this comment.
паттерн-матчинг для bool -- это сильно! Хватило бы и простого if, но не страшно.
| | Tree of 'a * Tree<'a> * Tree<'a> | ||
| | Empty | ||
|
|
||
| let treeFilter tree filter = |
There was a problem hiding this comment.
Достаточно оптимальное решение, однако задачу возможно решить через хвостовую рекурсию.
DedSec256
reviewed
Apr 22, 2022
| if List.isEmpty list then | ||
| raise (System.ArgumentException("Список пуст")) | ||
| else | ||
| List.fold (fun acc x -> if x < acc then x else acc) (List.head list) list |
There was a problem hiding this comment.
к слову, можно было через List.reduce min list (:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.