-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mrapp for cleanup and garbage collection #669
base: sub-main
Are you sure you want to change the base?
Conversation
Signed-off-by: hanbollar <github@hannahbollar.com>
Your Render PR Server URL is https://examples-mrjs-pr-669.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cp40soe3e1ms73choh2g. |
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
Signed-off-by: hanbollar <github@hannahbollar.com>
need to fix 'enter/exit' MR issue - otherwise it's ready to go |
swapping this back to |
cant swap - should keep sub-main as itself and then merge that in after this pr since that's still before the big refactor / breaking change |
since we're paused and this is really outdated - turning this into a draft for viewing, but we'll prob redo this / not need this in a bit |
Linking
Related to #677
Fixes #678
Problem
Description of the problem including potential code and/or screenshots as an example
Solution
Quick explanation of change to be done
Breaking Change
If this is a breaking change describe the before and after and why the change was necessary
Required to Merge
[ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.[ ] BREAKING CHANGE@lobau
@hanbollar