Skip to content

Conversation

@SebastianoF
Copy link

CHANGELOG

  • Invasive, possibly annoying, or possibly useful PR that delegates all stuff related to linting to ruff

PROS

  • one linter to rule them all
  • way faster to run the pre-commit hook
  • easy to move forward maintaining the code
  • a bug fixed in a jupyter notebook calling pd and never importing it
  • a few code smell removed

CONS

  • That's a loooooong PR to review

TESTS

  • no test added or changed. The only change is the code formatting

COMMENTS

  • Please note that I do not have an API key, so I could run only the tests that do not need one. In case the CI/CD does not re run those tests please run the tests with the key manually before productionisation!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant