Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for upcoming CHEZMOI_SOURCE_FILE #72

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

VorpalBlade
Copy link
Owner

@VorpalBlade VorpalBlade commented Jan 27, 2024

This will only work once twpayne/chezmoi#3518 has landed in a release of chezmoi

TODO:

  • Documentation:
    • Document in --help-syntax
    • Check README and elsewhere that might need updates
    • Document minimum required chezmoi version for this feature. Relevant locations:
      - CHEZMOI_AUTO_SOURCE_VERSION
      - source_specification.md
    • Release notes will need an expanded section on this (not just autogenerated from commit messages)
  • Functionality
    • Change default add-templates to make use of this
    • Should --add have a --templated (to add non-templated by default)? What about converting between them? Some thought needed for UX.
      Rolled into --style for now
    • Should default value of --style differ based on chezmoi version?
    • What should --add do when you have an old chezmoi? Do we need to parse the version number? :(
      Yes, though see below
    • What if you use a mix of old and new chezmoi across multiple computers, especially distro installed ones.

src/add.rs Fixed Show fixed Hide fixed
src/add.rs Fixed Show fixed Hide fixed
src/add/tests.rs Fixed Show fixed Hide fixed
src/add/tests.rs Fixed Show fixed Hide fixed
src/utils.rs Fixed Show fixed Hide fixed
src/utils.rs Fixed Show fixed Hide fixed
@VorpalBlade VorpalBlade force-pushed the feature/auto-env branch 2 times, most recently from d93595a to d431420 Compare January 27, 2024 23:05
@VorpalBlade VorpalBlade force-pushed the feature/auto-env branch 3 times, most recently from 567f1b2 to e5f82f3 Compare January 29, 2024 13:38
src/doctor.rs Fixed Show fixed Hide fixed
src/doctor.rs Fixed Show fixed Hide fixed
@VorpalBlade VorpalBlade force-pushed the feature/auto-env branch 7 times, most recently from 6e74126 to 3a3492f Compare February 3, 2024 19:13
@VorpalBlade VorpalBlade force-pushed the feature/auto-env branch 2 times, most recently from 199b251 to 4de3f3b Compare February 9, 2024 20:18
@VorpalBlade VorpalBlade merged commit d5b3d8d into main Feb 12, 2024
39 checks passed
@VorpalBlade VorpalBlade deleted the feature/auto-env branch February 12, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant