Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up specified directories during user deletion #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Clean up specified directories during user deletion #6

wants to merge 5 commits into from

Conversation

z4ab
Copy link

@z4ab z4ab commented Mar 31, 2024 •
edited by ben-z
Loading

Closes #1.
I decided to add a directories property to the config object so the the script can remove multiple directories. I could instead use a constant in the script that specifies the directories that need to be deleted, but I thought it would be inconsistent.

ben-z
ben-z reviewed Mar 31, 2024
View reviewed changes
Copy link
Member

@ben-z ben-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for taking the initiative. Can we make this a bit more general, and take in template strings instead? We can have the string handle %u and %U replacements automatically.

src/schema.mjs Outdated Show resolved Hide resolved
ben-z
ben-z reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@ben-z ben-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

src/index.mjs Outdated Show resolved Hide resolved
@z4ab @ben-z
Update index.mjs
8b84336 
Co-authored-by: Ben Zhang <ben-z@users.noreply.github.com>
ben-z
ben-z reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@ben-z ben-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Before we merge this, can you find your way around the infra-config repo and test this out on some dummy user? It might take some looking around, but the relevant pieces are:

https://github.com/WATonomous/infra-config/blob/8b60dcab1b334cef1e45719156f836529c2c6ad1/ansible/roles/users/tasks/main.yml#L41-L51

https://github.com/WATonomous/infra-config/blob/8b60dcab1b334cef1e45719156f836529c2c6ad1/ansible/roles/users/tasks/main.yml#L36-L39

https://github.com/WATonomous/infra-config/blob/8b60dcab1b334cef1e45719156f836529c2c6ad1/ansible/filter_plugins/directory_filters.py#L6

https://github.com/WATonomous/infra-config/blob/8b60dcab1b334cef1e45719156f836529c2c6ad1/README.md#developing-a-provisioner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-z ben-z ben-z left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a way to clean up specified directories during user deletion
2 participants
@z4ab @ben-z