Merged
Conversation
[Terraform Plan Summary]
Plan OutputNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed. |
[Terraform Plan Summary]
Plan OutputNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed. |
[Terraform Plan Summary]
Plan OutputNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed. |
[Terraform Plan Summary]
Plan OutputNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed. |
💰 Infracost reportMonthly estimate generatedThis comment will be updated when code changes. |
[Terraform Plan Summary]
Plan OutputNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed. |
sh1220
approved these changes
Jul 15, 2025
Contributor
sh1220
left a comment
sh1220
left a comment
There was a problem hiding this comment.
확인했습니다. plan 결과에 대한 ux가 더 좋아진 것 같아서 좋네요.
ci와 cd에 대한 파일 변경 탐지 질문 답변 부탁드려요!
| - 'management-team-account/**' | ||
|
|
||
|
|
||
| - name: Build Matrix from Filter (with subdirs) |
Contributor
There was a problem hiding this comment.
현재 ci와 cd의 변경 파일 탐지 로직이 다르네요.
cd는 filter 방식이고, ci는 git diff 기반으로 탐지하는 것 같은데
ci가 변경사항 탐지는 더 정확해 보여요.
그래서 cd는 폴더 기준으로 돌아가는 것 같은데 방식을 통일할 생각도 있으실까요?
Contributor
Author
There was a problem hiding this comment.
처음에는 CD도 git diff로 변경 사항을 탐지하려 했지만, 머지 후에는 기준이 불분명해져 잘 작동하지 않았어요.
그래서 CD는 필터 기반으로 탐지하는 것이 더 적합하다고 판단했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issues
📝 Work Summary
Supersedes #33
Screenshot (Optional)
💬 Review Notes (Optional)