Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused config size attributes #182

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Remove unused config size attributes #182

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc754b0
Remove unused config size attributes
VergeA Aug 19, 2024
7a51c0e
Remove unused typedefs
VergeA Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 3 additions & 85 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,9 @@ boundary, which can allow for colluding parties to join cross-site data and buil
user. To prevent that, the ad auction API [=construct a pending fenced frame config|constructs=] a
[=fenced frame config=] whose underlying [=fenced frame config/mapped url|URL=] is opaque to the
embedding context. The [=fenced frame config=] is also constructed with restrictions on what the
[=fenced frame config/container size=] and [=fenced frame config/content size=] of the frame must be
and what the [=fenced frame config/effective enabled permissions|permissions policy=] of the frame
must be, as those can be used as fingerprinting vectors.
[=fenced frame config/content size=] of the frame must be and what the [=fenced frame config/
effective enabled permissions|permissions policy=] of the frame must be, as those can be used as
fingerprinting vectors.

Displaying a personalized payment button:

Expand Down Expand Up @@ -1072,9 +1072,6 @@ A <dfn export>fenced frame config</dfn> is a [=struct=] with the following [=str
: <dfn for="mapped url">visibility</dfn>
:: a [=fencedframeconfig/visibility=]

: <dfn>container size</dfn>
:: null, or a [=fencedframetype/size=]

: <dfn>content size</dfn>
:: null, or a [=struct=] with the following [=struct/items=]:
: <dfn for="content size">value</dfn>
Expand Down Expand Up @@ -1171,9 +1168,6 @@ A <dfn export>fenced frame config instance</dfn> is a [=struct=] with the follow
: <dfn>mapped url</dfn>
:: a [=URL=]

: <dfn>container size</dfn>
:: null, or a [=fencedframetype/size=]

: <dfn>content size</dfn>
:: null, or a [=fencedframetype/size=]

Expand Down Expand Up @@ -1219,9 +1213,6 @@ A <dfn export>fenced frame config instance</dfn> is a [=struct=] with the follow
: [=fenced frame config instance/mapped url=]
:: |config|'s [=fenced frame config/mapped url=]'s [=mapped url/value=]

: [=fenced frame config instance/container size=]
:: |config|'s [=fenced frame config/container size=]

: [=fenced frame config instance/content size=]
:: |config|'s [=fenced frame config/content size=] if null, otherwise |config|'s [=fenced frame
config/content size=]'s [=content size/value=]
Expand Down Expand Up @@ -1324,12 +1315,6 @@ maps to an internal [=fenced frame config=] [=struct=].
[Exposed=Window, Serializable]
interface FencedFrameConfig {
constructor(USVString url);

readonly attribute FencedFrameConfigSize? containerWidth;
readonly attribute FencedFrameConfigSize? containerHeight;
readonly attribute FencedFrameConfigSize? contentWidth;
readonly attribute FencedFrameConfigSize? contentHeight;
VergeA marked this conversation as resolved.
Show resolved Hide resolved

undefined setSharedStorageContext(DOMString contextString);
};
</pre>
Expand All @@ -1339,10 +1324,6 @@ Each {{FencedFrameConfig}} has:
* A <dfn for=fencedframeconfig>url</dfn>, a [=URL=], failure, or null, initially null
* A <dfn for=fencedframeconfig>urn</dfn>, a [=urn uuid=]
* A <dfn for=fencedframeconfig>sharedStorageContext</dfn>, a [=string=]
* A <dfn for=fencedframeconfig>containerWidth</dfn>, a {{FencedFrameConfigSize}} or null
* A <dfn for=fencedframeconfig>containerHeight</dfn>, a {{FencedFrameConfigSize}} or null
* A <dfn for=fencedframeconfig>contentWidth</dfn>, a {{FencedFrameConfigSize}} or null
* A <dfn for=fencedframeconfig>contentHeight</dfn>, a {{FencedFrameConfigSize}} or null

Note: A config's [=fencedframeconfig/url=] is only null if a [=fencedframeconfig/urn=] is supplied.

Expand All @@ -1357,26 +1338,6 @@ Note: A config's [=fencedframeconfig/url=] is only null if a [=fencedframeconfig
1. Return |config|.
</div>

<div algorithm="containerWidth getter">
The {{FencedFrameConfig/containerWidth}} IDL attribute getter steps are to return [=this=]'s
[=fencedframeconfig/containerWidth=].
</div>

<div algorithm="containerHeight getter">
The {{FencedFrameConfig/containerHeight}} IDL attribute getter steps are to return [=this=]'s
[=fencedframeconfig/containerHeight=].
</div>

<div algorithm="contentWidth getter">
The {{FencedFrameConfig/contentWidth}} IDL attribute getter steps are to return [=this=]'s
[=fencedframeconfig/contentWidth=].
</div>

<div algorithm="contentHeight getter">
The {{FencedFrameConfig/contentHeight}} IDL attribute getter steps are to return [=this=]'s
[=fencedframeconfig/contentHeight=].
</div>

<div algorithm>
The <dfn method for=FencedFrameConfig>setSharedStorageContext(|contextString|)</dfn> method steps
are to set [=this=]'s [=fencedframeconfig/sharedStorageContext=] to |contextString|.
Expand All @@ -1394,20 +1355,6 @@ Note: A config's [=fencedframeconfig/url=] is only null if a [=fencedframeconfig

1. Set |serialized|.\[[SharedStorageContext]] to |value|'s [=fencedframeconfig/
sharedStorageContext=].

1. Set |serialized|.\[[ContainerWidth]] to |value|'s [=fencedframeconfig/
containerWidth=].

1. Set |serialized|.\[[ContainerHeight]] to |value|'s [=fencedframeconfig/
containerHeight=].

1. Set |serialized|.\[[ContentWidth]] to |value|'s [=fencedframeconfig/
contentWidth=].

1. Set |serialized|.\[[ContentHeight]] to |value|'s [=fencedframeconfig/
contentHeight=].


</div>

<div algorithm="FencedFrameConfig deserializer">
Expand All @@ -1420,15 +1367,6 @@ Note: A config's [=fencedframeconfig/url=] is only null if a [=fencedframeconfig

1. Initialize |value|'s [=fencedframeconfig/sharedStorageContext=] to
|serialized|.\[[SharedStorageContext]].

1. Initialize |value|'s [=fencedframeconfig/containerWidth=] to |serialized|.\[[ContainerWidth]].

1. Initialize |value|'s [=fencedframeconfig/containerHeight=] to
|serialized|.\[[ContainerHeight]].

1. Initialize |value|'s [=fencedframeconfig/contentWidth=] to |serialized|.\[[ContentWidth]].

1. Initialize |value|'s [=fencedframeconfig/contentHeight=] to |serialized|.\[[ContentHeight]].
</div>

Note: To help with ease of adoption,
Expand Down Expand Up @@ -1809,26 +1747,6 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface.
: [=fencedframeconfig/sharedStorageContext=]
:: |config|'s [=fenced frame config/embedder shared storage context=]

: [=fencedframeconfig/containerWidth=]
:: null if |config|'s [=fenced frame config/container size=] is null, otherwise |config|'s
[=fenced frame config/container size=]'s [=size/width=]

: [=fencedframeconfig/containerHeight=]
:: null if |config|'s [=fenced frame config/container size=] is null, otherwise |config|'s
[=fenced frame config/container size=]'s [=size/height=]

: [=fencedframeconfig/contentWidth=]
:: null if |config|'s [=fenced frame config/content size=] is null, the `"opaque"`
{{OpaqueProperty}} if |config|'s [=fenced frame config/content size=]'s [=content
size/visibility=] is [=visibility/opaque=], otherwise |config|'s [=fenced frame
config/content size=]'s [=size/width=]

: [=fencedframeconfig/contentHeight=]
:: null if |config|'s [=fenced frame config/content size=] is null, the `"opaque"`
{{OpaqueProperty}} if |config|'s [=fenced frame config/content size=]'s [=content
size/visibility=] is [=visibility/opaque=], otherwise |config|'s [=fenced frame
config/content size=]'s [=size/height=]

1. [=list/Append=] |newConfig| to |results|.

1. Return |results|.
Expand Down
Loading