-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Add interestGroups() #203
Open
xyaoinum
wants to merge
3
commits into
main
Choose a base branch
from
yao-expose-igs-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the Shared Storage side's spec update to support interestGroups() within shared storage worklet (#180). Sibling spec update PR for Protected Audience: WICG/turtledove#1299.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1369483}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1369483}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#1369483}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Shared Storage side's spec update to support interestGroups() within shared storage worklet (#180). Sibling spec update PR for Protected Audience: WICG/turtledove#1299.
Preview | Diff