Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Qingxin Wu committed Sep 26, 2024
1 parent 78366f3 commit 7169bad
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -1154,8 +1154,6 @@ To <dfn>validate and convert auction ad config</dfn> given an {{AuctionAdConfig}
|config|["{{AuctionAdConfig/serverResponse}}"].
1. Set |auctionConfig|'s [=auction config/server response id=] to
|config|["{{AuctionAdConfig/requestId}}"].
1. If no exception was [=exception/thrown=] in the previous step, then decrement
|auctionConfig|'s [=auction config/pending promise count=].
1. [=Upon rejection=] of |resolvedAndTypeChecked|:
1. Set |auctionConfig|'s [=auction config/server response=] to failure.

Expand Down Expand Up @@ -2809,7 +2807,8 @@ a [=list=] of [=interest groups=] |bidIgs|, and a [=list=] of [=bid debug report
|bidDebugReportInfoList|, perform the following steps. They return a [=leading bid info=] or a failure.

1. [=Assert=] that these steps are running [=in parallel=].
1. If [=wait until server response promise resolve=] returns failure, then return failure.
1. If [=waiting until server response promise resolves=] given |auctionConfig| returns failure, then
return failure.
1. Let |hash| be the [=SHA-256=] of |auctionConfig|'s [=auction config/server response=].
1. Let |capturedAuctionHeaders| be |global|'s [=associated Document's=] [=node navigable's=]
[=traversable navigable's=] [=traversable navigable/captured ad auction result headers=].
Expand Down Expand Up @@ -6548,7 +6547,7 @@ a {{Promise}} |p|, and two sequences of steps, covering the parsing of the value
</div>

<div algorithm>
To <dfn>wait until server response promise resolve</dfn> given an [=auction config=] |auctionConfig|:
To <dfn>wait until server response promise resolves</dfn> given an [=auction config=] |auctionConfig|:

1. Wait until either |auctionConfig|'s [=auction config/server response=] is not a {{Promise}},
or |auctionConfig|'s [=auction config/aborted=] is true.
Expand Down

0 comments on commit 7169bad

Please sign in to comment.