[SPEC] Deals #1275
Merged
[SPEC] Deals #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orrb1
reviewed
Sep 11, 2024
orrb1
reviewed
Sep 12, 2024
spec.bs
Outdated
| 1. Let |igAd| be the [=interest group ad=] from |generatedBid|'s [=generated bid/interest group=]'s | ||
| [=interest group/ads=] whose [=interest group ad/render url=] is |generatedBid|'s | ||
| [=generated bid/ad descriptor=]'s [=ad descriptor/url=]. | ||
| 1. If both of the following return true: |
There was a problem hiding this comment.
These four lines (7081-7084) seem to be an incomplete transition. Is this correct?
1. If [=query generated bid k-anonymity count=] given |generatedBid| returns true AND
(|generatedBid|'s [=generated bid/selected buyer and seller reporting ID=] does not [=map/exists|exist=] OR
[=query reporting ID k-anonymity count=] given |generatedBid|'s [=generated bid/interest group=], |igAd|,
and the |generatedBid|'s [=generated bid/selected buyer and seller reporting ID=] is true), then:
1. [=list/Append=] |generatedBid| to |bidsToScore|.
This formation allows you to also remove these two lines above:
1. Let |selectedReportingId| be a [=string=]-or-null that is set to null.
1. If |generatedBid|'s [=generated bid/selected buyer and seller reporting ID=] [=map/exists=], set |selectedReportingId| to it.
There was a problem hiding this comment.
Hmm This seemed to have been in a messed up state. I restructured it based on your comments. However I left creating the variables because I feel as though it makes that long if statement easier to understand. Let me know what you think.
qingxinwu
reviewed
Sep 16, 2024
qingxinwu
reviewed
Sep 17, 2024
qingxinwu
reviewed
Sep 19, 2024
qingxinwu
reviewed
Sep 20, 2024
|
almost there. |
qingxinwu
reviewed
Sep 20, 2024
qingxinwu
reviewed
Sep 23, 2024
qingxinwu
approved these changes
Sep 23, 2024
|
LGTM |
orrb1
reviewed
Oct 2, 2024
orrb1
reviewed
Oct 4, 2024
orrb1
reviewed
Oct 4, 2024
orrb1
reviewed
Oct 10, 2024
orrb1
reviewed
Oct 15, 2024
orrb1
approved these changes
Oct 15, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 16, 2024
SHA: bdc705b Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Spec changes for Deals support.
Preview | Diff