Spec: add some shared infra for reporting, and port forDebugOnly to it. #1296
Conversation
| 1. [=list/For each=] |generatedBid| of |generatedBids|: | ||
| 1. If |generatedBid|'s [=generated bid/for k-anon auction=] is true: |
There was a problem hiding this comment.
...I need to figure out how to not report the non-k-anon run properly, I think it's wrong right now.
There was a problem hiding this comment.
OK, not too hard, but I am wondering about what we should do about platform realtime contributions here --- I think in impl we don't keep them for non-k-anon scoreAd run, while it's actually annoying to make the spec say that, and I am not sure it should.
There was a problem hiding this comment.
Done'ish. Also fixed additional bids not participating in non-k-anon auction.
| : <dfn>source</dfn> | ||
| :: A [=reporting bid source=] describing where the bid came from. | ||
| : <dfn>origin</dfn> | ||
| :: The [=origin=] of the bidder. |
There was a problem hiding this comment.
An [=origin=]. The bidding [=interest group=]'s [=interest group/owner=]?
There was a problem hiding this comment.
There is not necessarily an interest group... which makes my bidding of the next field is dubious.
| originated in. | ||
| : <dfn>source</dfn> | ||
| :: A [=reporting bid source=] describing where the bid came from. | ||
| : <dfn>origin</dfn> |
spec.bs
Outdated
| : <dfn>origin</dfn> | ||
| :: The [=origin=] of the bidder. | ||
| : <dfn>interest group name</dfn> | ||
| :: A [=string=] uniquely identifying the interest group. |
There was a problem hiding this comment.
A [=string=]. The bidding [=interest group=]'s [=interest group/name=]?
And it's the owner/name pair that uniquely identifies the IG, right?
spec.bs
Outdated
|
|
||
| </dl> | ||
|
|
||
| Note: This type exists only to uniquely identify places bid came from, avoiding confusion in |
There was a problem hiding this comment.
maybe move this note to right after the "A reporting bid key" line, before the <dl>?
There was a problem hiding this comment.
...And the validator seems to dislike it, so reverted.
There was a problem hiding this comment.
I meant before <dl> some lines above, not </dl>. It's not allowed to put "Note" into a <dl> block. But I'm fine with keeping the note here as well.
| : [=reporting bid key/origin=] | ||
| :: |ig|'s [=interest group/owner=] | ||
| : [=reporting bid key/interest group name=] | ||
| :: A string representation of a new globably unique identifier. This is needed since |igName| |
There was a problem hiding this comment.
is this field not the IG name? But it seems to be IG name here: https://github.com/WICG/turtledove/pull/1296/files#diff-6f5a1d8263b0b0c42e2716ba5750e3652e359532647ac934c1c70086ae3ceddaR3506
There was a problem hiding this comment.
It's interest group name for regular interest groups. For additional bids it can't be, since there is nothing saying that they have to provide a unique interest group name. (And now I am scared of something in our impl breaking because of that...).
There was a problem hiding this comment.
So renamed this. The new description is kinda vague, but it does I think clarify that one can't expect it to be an IG name.
| : <dfn>source</dfn> | ||
| :: A [=reporting bid source=] describing where the bid came from. | ||
| : <dfn>origin</dfn> | ||
| :: The [=origin=] of the bidder. |
There was a problem hiding this comment.
There is not necessarily an interest group... which makes my bidding of the next field is dubious.
spec.bs
Outdated
|
|
||
| </dl> | ||
|
|
||
| Note: This type exists only to uniquely identify places bid came from, avoiding confusion in |
This is intended to be used for moving our Private Aggregation support into our spec, as it provides:
vague on how the top-level scope should work still).
...for now, forDebugOnly is what's ported to it, and while at it, things were fixed to actually pass the argument needed for reporting to scoreAd invocations, and to fix up additional bids (and B&A) for it.
It may make sense to move realTimeContributions in there as well, though it doesn't really benefit from any functionality besides maybe avoiding a parameter sometimes (and the split is kinda harmful).
Preview | Diff