Add spec for multi-seller getInterestGroupAdAuctionData #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qingxinwu PTAL |
qingxinwu
reviewed
Jan 24, 2025
| 1. Let |requestId| be the [=string representation=] of a [=version 4 UUID=]. | ||
| 1. [=list/For each=] |config| in |configs|: |
There was a problem hiding this comment.
nit
Suggested change
| 1. [=list/For each=] |config| in |configs|: | |
| 1. [=list/For each=] |config| of |configs|: |
| and |config|'s [=auction data config/request size=] is null: | ||
| 1. Let |requestSize| be 0. | ||
| 1. [=list/For each=] |buyerConfig| of |config|'s [=auction data config/per buyer config=]'s [=map/values=]: | ||
| 1. Let |configs| be a new empty [=list=]. |
There was a problem hiding this comment.
When possible, be explict about the element type in the list.
nit: "new" is enough.
Suggested change
| 1. Let |configs| be a new empty [=list=]. | |
| 1. Let |configs| be a new [=list=] of [=auction data configs=]. |
| 1. Let |requestSize| be 0. | ||
| 1. [=list/For each=] |buyerConfig| of |config|'s [=auction data config/per buyer config=]'s [=map/values=]: | ||
| 1. Let |configs| be a new empty [=list=]. | ||
| 1. Let |per buyer configs| be the result of running [=parse per buyer auction data configs=] on |
| 1. If |configIDL|["{{AdAuctionDataConfig/seller}}"] [=map/exists=]: | ||
| 1. Let |seller| be the result of running [=parse an https origin=] on | ||
| |configIDL|["{{AdAuctionDataConfig/seller}}"]. | ||
| 1. Let |coordinator| be the result of running [=parse an https origin=] on |
There was a problem hiding this comment.
now, we need to check whether |configIDL|["{{AdAuctionDataConfig/coordinatorOrigin}}"] [=map/exists=] first, since it's no longer required in IDL. Set |coordinator| to a default coordinator when it does not exist.
| 1. Otherwise: | ||
| 1. If |configIDL|["{{AdAuctionDataConfig/sellers}}"] does not [=map/exist=], then [=exception/throw=] a {{TypeError}}. | ||
| 1. If |configIDL|["{{AdAuctionDataConfig/coordinatorOrigin}}"] [=map/exists=], then [=exception/throw=] a {{TypeError}}. | ||
| 1. [=list/For each=] |seller config| in |configIDL|["{{AdAuctionDataConfig/sellers}}"]: |
There was a problem hiding this comment.
|sellerConfig|. There are several variables defined like this. Please check and fix those too.
| 1. [=list/For each=] |seller config| in |configIDL|["{{AdAuctionDataConfig/sellers}}"]: | ||
| 1. Let |seller| be the result of running [=parse an https origin=] on | ||
| |seller config|["{{AdAuctionOneSeller/seller}}"]. | ||
| 1. If |configs| already [=list/contains=] a [=auction data config=] whose |
There was a problem hiding this comment.
Suggested change
| 1. If |configs| already [=list/contains=] a [=auction data config=] whose | |
| 1. If |configs| [=list/contains=] an [=auction data config=] whose |
| 1. If |configs| already [=list/contains=] a [=auction data config=] whose | ||
| [=auction data config/seller=] is equal to |seller|, then | ||
| [=exception/throw=] a {{TypeError}}. | ||
| 1. Let |coordinator| be the result of running [=parse an https origin=] on |
There was a problem hiding this comment.
same, need to check if |seller config|["{{AdAuctionOneSeller/coordinatorOrigin}}"] exists?
| coordinators supported by this [=user agent=]: | ||
| 1. Let |result| be a new [=auction data seller result=] with the following [=struct/items=]: | ||
| : [=auction data seller result/seller=] | ||
| :: |seller| |
There was a problem hiding this comment.
not defined. Need to define it as |config|'s seller somewhere above.
| @@ -3786,20 +3791,72 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|configIDL|)</dfn> m | |||
| 1. [=list/Append=] |serverIg| to |igMap|[|owner|]. | |||
| 1. If |ig|'s [=interest group/Private Aggregation coordinator=] is not null, then [=map/set=] | |||
| |igPAggCoordinatorMap|[(|owner|, |name|)] to it. | |||
| 1. Let |result| be a new {{AdAuctionData}}. | |||
| 1. Let |results| be a new [=list=]. | |||
There was a problem hiding this comment.
Suggested change
| 1. Let |results| be a new [=list=]. | |
| 1. Let |results| be a new [=list=] of [=auction data seller results=]. |
| 1. Set |requestContext|'s [=server auction request context/request context=] field to |context|. | ||
| 1. [=map/Set=] |global|'s [=associated Document's=] [=node navigable's=] | ||
| [=traversable navigable's=] [=traversable navigable/saved Bidding and Auction request context=][|requestId|] to |requestContext|. | ||
| 1. Let |result| be a new {{AdAuctionData}}. |
There was a problem hiding this comment.
a different |result| was used above. Let's change one of the names to make it more readable.
|
[sad] David Dabbs reacted to your message:
…________________________________
From: brusshamilton ***@***.***>
Sent: Thursday, January 23, 2025 9:49:42 PM
To: WICG/turtledove ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [WICG/turtledove] Add spec for multi-seller getInterestGroupAdAuctionData (PR #1389)
External to the Groupe / en provenance de l'extérieur du Groupe
@qingxinwu<https://github.com/qingxinwu> PTAL
—
Reply to this email directly, view it on GitHub<#1389 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABK3LDH2AROHGVF5KV6F7D2MFPXNAVCNFSM6AAAAABVV7TDUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGA4DONJRHE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
------------------------------------------------------------------------
Disclaimer The information in this email and any attachments may contain proprietary and confidential information that is intended for the addressee(s) only. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, retention or use of the contents of this information is prohibited. When addressed to our clients or vendors, any information contained in this e-mail or any attachments is subject to the terms and conditions in any governing contract. If you have received this e-mail in error, please immediately contact the sender and delete the e-mail.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff