Add more details to the Chrome bidding and auction server API #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust format and ad more details
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 13, 2023
This will be used when we complete auction in browser. Related resources: https://github.com/WICG/turtledove/blob/main/FLEDGE_browser_bidding_and_auction_API.md#step-4-complete-auction-in-browser WICG/turtledove#602 Bug: 1442274 Change-Id: If35959def123d3cc30ed7ef0366fc9a186cbbfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595558 Reviewed-by: Russ Hamilton <behamilton@google.com> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Youssef Bourouphael <ybourouphael@google.com> Cr-Commit-Position: refs/heads/main@{#1157121}
JensenPaul
reviewed
Jun 22, 2023
JensenPaul
added
the
Non-breaking Feature Request
|
I fixed the merge issues and clarified the framing we are using. PTAL |
JensenPaul
reviewed
Sep 5, 2023
JensenPaul
reviewed
Sep 11, 2023
|
I think I addressed all of the outstanding comments. PTAL |
github-actions bot
added a commit
that referenced
this pull request
Sep 12, 2023
SHA: 0f50df9 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.