Fix a number of imprecisions in GenerateBidOutput handling: #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The return value of generateBid() always wins over setBid if the function completed normally; even if it's invalid. 2. setBid doesn't return true/false, it throws on invalid input. 3. 'render' is not strictly required: if the bid value is <= 0 the object is a valid representation of not bidding regardless of other fields; this is relevant because doing setBid() with it does not throw. 4. modelingSignals is actually an unrestricted double: the explainer has NaN/inf/-inf as ignored, and conveniently none of these are in the [0, 4095) range anyway. I've also scooted over the zero-argument setBid() next to its full-functioned sibling, rather than separated by a giant algorithm.
morlovich
commented
Jun 23, 2023
domfarolino
reviewed
Jun 24, 2023
domfarolino
reviewed
Jul 6, 2023
domfarolino
approved these changes
Jul 7, 2023
qingxinwu
reviewed
Jul 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Jul 12, 2023
SHA: 66cc6c2 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Jul 13, 2023
SHA: 66cc6c2 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 Error: 400 Bad Request 💥
PR Preview failed to build. (Last tried on Jul 12, 2023, 2:53 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.