Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the wrong service-worker mode. #733

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Fix the wrong service-worker mode. #733

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39d7683
Fix the wrong service-worker mode.
Jul 27, 2023
5a20e4e
Merge branch 'WICG:main' into fix
qingxinwu Aug 15, 2023
04689fb
Merge branch 'WICG:main' into fix
qingxinwu Aug 18, 2023
6ed0a8f
Merge branch 'WICG:main' into fix
qingxinwu Aug 28, 2023
7fb5296
Add notes about service worker interception.
Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,6 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
:: «`Accept`: `application/json`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/origin=]
:: |frameOrigin|
: [=request/mode=]
Expand All @@ -361,6 +359,9 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |resource| be null.
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
[=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
Expand Down Expand Up @@ -1532,8 +1533,6 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
:: «`Accept`: `text/javascript`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -1542,6 +1541,9 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |script| be null.
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
[=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
Expand All @@ -1563,8 +1565,6 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
:: «`Accept`: `application/wasm`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -1573,6 +1573,9 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |moduleObject| be null.
1. [=Fetch=] |request| with [=fetch/processResponseConsumeBody=] set to the following steps given
a [=response=] |response| and null, failure, or a [=byte sequence=] |responseBody|:
Expand Down Expand Up @@ -1602,8 +1605,6 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
:: «`Accept`: `application/json`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -1612,6 +1613,9 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.
1. Let |signals| be null.
1. Let |dataVersion| be null.
1. Let |formatVersion| be null.
Expand Down Expand Up @@ -2628,8 +2632,6 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
:: «`Accept`: `application/json`»
: [=request/client=]
:: `null`
: [=request/service-workers mode=]
:: "`none`"
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
Expand All @@ -2638,6 +2640,9 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"

Issue: One of the side-effects of a `null` client for this subresource request is it neuters
all service worker interceptions, despite not having to set the service workers mode.
1. Let |update| be null.
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
[=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
Expand Down