Make <dfn>s on the structs, instead of on the headers #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingxinwu
changed the title
qingxinwu
changed the title
qingxinwu
changed the title
|
@caraitto Mind taking a look at this? Using the split diff view and select "hide spaces" will make the PR easier to review. Thanks! |
domfarolino
approved these changes
Jan 3, 2024
|
Still lgtm |
github-actions bot
added a commit
that referenced
this pull request
Jan 9, 2024
SHA: 2a80ffe Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Jan 9, 2024
SHA: 2a80ffe Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dl { padding-left: 1em; }css rule, to indent<dl>s 1em to make them more readable in the spec.The spec defined structs on the section headers (e.g.,
<h3 dfn-type=dfn>Generated bid</h3>). The definition of "generated bid" is changed to the struct (e.g., A<dfn>generated bid</dfn> is a bid ...). This is suggested by this comment.Reorgnized the headers for structs, to only keep headers for the top level structs, and the helper structs grouped under the same header.
Link to [:Data-Version:] header correctly.
"HTTPS origins" -> "[=origin/scheme=] is "
https".Update some algorithm's format/indent.
Preview | Diff