Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination (#369) #404

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

huyuxin0429
Copy link
Collaborator

This reverts commit d6a720f.

  • Fix extra render when uploading invalid zip file

  • Add API route for GET Pair of flagged submission details (GET Pair of flagged submission details #341)

  • Add tests and bug fixes for api/v1/submission_similarities index and show

  • Add RSpec tests for POST /api/v1/courses/{course_id}/assignment/

  • Update similarity percentage format it doc

  • Remove unused files and routes

  • Update/ Clarify API doc

  • added pagination

  • added to use the will_paginate gem

  • Added such that limit has higher precedence over pagination


Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

mengyewgau and others added 2 commits January 15, 2024 22:32
* Adds POST route for creating new assignments via API (#338)

* Add API key and sample GET and POST

* Implement POST API route for creating assignments

* Add API key authentication handler

* Run rubocop on assignments_controller

* Reduce linter-flagged issues

* Add API Phase 1 documentation (#336)

* Add API Phase 1 documentation

* Api/sub sim (#331)

* Added API for GET all submission similarities of an assignment

* Fix extra render when uploading invalid zip file (#342)

* Fix extra render when uploading invalid zip file

* Revert "Fix extra render when uploading invalid zip file (#342)" (#344)

This reverts commit d6a720f.

* Fix extra render when uploading invalid zip file

* Add API route for GET Pair of flagged submission details (#341)

* Add tests and bug fixes for api/v1/submission_similarities index and show

* Add RSpec tests for POST /api/v1/courses/{course_id}/assignment/

* Update similarity percentage format it doc

* Remove unused files and routes

* Update/ Clarify API doc

* added pagination

* added to use the will_paginate gem

* Added such that limit has higher precedence over pagination

---------

Co-authored-by: sibinhho99 <sibinhho99@gmail.com>
Co-authored-by: florentianayuwono <76247368+florentianayuwono@users.noreply.github.com>
@huyuxin0429 huyuxin0429 merged commit 1475bcb into master Jan 15, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 4.43% (+0.2%) from 4.203%
when pulling fbf3a72 on feature/ssid_coursemology_integration
into 8bcd107 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants