Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

WWDC2023 10057 - Unleash the UIKit trait system #451

Merged
merged 2 commits into from
Nov 12, 2023
Merged

WWDC2023 10057 - Unleash the UIKit trait system #451

merged 2 commits into from
Nov 12, 2023

Conversation

srujanc
Copy link
Contributor

@srujanc srujanc commented Nov 10, 2023

No description provided.

Jeehut
Jeehut reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just found this potential issue. Please take a look.

content/notes/wwdc23/10057.md Outdated

```

[!Note] traitCollectionDidChange is deprecated in iOS 17. When you implement traitCollectionDidChange, the system doesn’t know which traits you actually care about, so it has to call that method every time that any trait changes value. However, most classes only use a handful of traits and don’t care about changes to any others. This is why traitCollectionDidChange doesn’t scale as you add more and more custom traits.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is [!Note] supposed to be a link or an image? I can't seem to find it, could be broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Code @Jeehut Tq

@Jeehut Jeehut merged commit 7b6ca74 into WWDCNotes:main Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jeehut Jeehut Jeehut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srujanc @Jeehut