This repository was archived by the owner on Jun 24, 2024. It is now read-only.
Update 10160.md #454
Merged
Update 10160.md #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix code for unknown views per element, add code for other cases in List usage, small code clean in other places
Jeehut
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
This looks good overall, thank you!
I'm gonna merge, then remove your name though, as stated in the guidelines here for a small change like adjusting indentation which is mostly the case here, you should not add your name. This is reserved for more substantial changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code for unknown views per element, add code for other cases in List usage, small code cleanup in other places