Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dispose loop #128

Merged
merged 2 commits into from
Oct 16, 2023
Merged

fix: dispose loop #128

merged 2 commits into from
Oct 16, 2023

Conversation

gigajuwels
Copy link
Contributor

@gigajuwels gigajuwels commented Oct 4, 2023 •
edited
Loading

@gigajuwels gigajuwels mentioned this pull request Oct 4, 2023
Merged
@skibitsky
Copy link
Member

@gigajuwels I suggest completely removing these calls to Dispose() and maintaining a codebase free from commented-out code.

@skibitsky skibitsky self-requested a review October 16, 2023 06:04
@skibitsky skibitsky merged commit 86a0343 into 2.0 Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skibitsky skibitsky skibitsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack Overflow on Dispose
2 participants
@gigajuwels @skibitsky