Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate wc_sessionRequest handlers issue #187

Closed

Conversation

aliarbak
Copy link

@aliarbak aliarbak commented May 5, 2024

Fix: #188

@aliarbak aliarbak changed the title fix: duplicate wc_sessionRequest handler issue fix: duplicate wc_sessionRequest handlers issue May 5, 2024
@skibitsky
Copy link
Member

Hey @aliarbak,

Thank you for opening the issue with detailed information and submitting the pull request. I managed to reproduce the issue but cannot approve the pull request due to compatibility issues with the WalletConnect protocol.

The changes made to the Sign project ensure that unit tests pass, as both wallets and dapps in our unit tests use the same Sign project. However, when using the updated Sign project with any third-party wallet or our react sample wallet, you will notice that session requests are not coming through.

Upon comparing the requests generated by your PR to the stable release, I noticed that in your version, the wc_sessionRequest is replaced with the method name from the message payload.

Left: personal_sign session request from the PR. Right: personal_sign session request from the latest stable release.
Screenshot 2024-05-06@2x

@aliarbak
Copy link
Author

aliarbak commented May 6, 2024

Hey @skibitsky thank you for your reply. Then it would be better to find a safer workaround without changing the request values. nice catch btw :)

@skibitsky
Copy link
Member

@aliarbak #193

@skibitsky skibitsky closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants