Open
Conversation
Owner
|
Thank you for this contribution! |
Wandmalfarbe
requested changes
Aug 3, 2020
Owner
Wandmalfarbe
left a comment
Wandmalfarbe
left a comment
There was a problem hiding this comment.
Please also change the lines
# show an error message and exit if the bouwkamp code is invalid
try:
self.exception_on_invalid_bouwkamp_code(bouwkamp_code)
except ValueError as exception:
inkex.errormsg(_(exception.message))
returnto
# show an error message and exit if the bouwkamp code is invalid
try:
self.exception_on_invalid_bouwkamp_code(bouwkamp_code)
except ValueError as exception:
inkex.errormsg(_(str(exception)))
returnto make it Python 3 compliant. The class ValueError has no attribute message anymore.
| default='21, 112, 112, [50, 35, 27], [8, 19], [15, 17, ' + | ||
| '11], [6, 24], [29, 25, 9, 2], [7, 18], [16], [42], [4, 37], [33]', | ||
| help='The Bouwkamp code.' | ||
| self.arg_parser.add_argument('--tab') |
Owner
There was a problem hiding this comment.
Please restore the original indentation and line wrapping on the add_argument-calls.
| '11], [6, 24], [29, 25, 9, 2], [7, 18], [16], [42], [4, 37], [33]', | ||
| help='The Bouwkamp code.' | ||
| self.arg_parser.add_argument('--tab') | ||
| self.arg_parser.add_argument('--bouwkamp_code', default='21, 112, 112, [50, 35, 27], [8, 19], [15, 17, 11], [6, 24], [29, 25, 9, 2], [7, 18], [16], [42], [4, 37], [33]', help='The Bouwkamp code.' |
Owner
There was a problem hiding this comment.
The correct argument name is --bouwkamp-code.
| dest='wrap_in_group', | ||
| default=True, | ||
| help='Should the generated items be wrapped inside a group.' | ||
| self.arg_parser.add_argument('--wrap_in_group', type=inkex.Boolean, default=True, help='Should the generated items be wrapped inside a group.' |
Owner
There was a problem hiding this comment.
The correct argument name is --wrap-in-group.
Wandmalfarbe
requested changes
Dec 6, 2020
| @@ -2,14 +2,10 @@ | |||
| <inkscape-extension xmlns="http://www.inkscape.org/namespace/inkscape/extension"> | |||
Owner
There was a problem hiding this comment.
Please revert this commit. The parameter names bouwkamp-code and wrap-in-group were correct and should not be changed.
render_bouwkamp_code.inx
Outdated
| <submenu _name="Render"/> | ||
| <submenu _name="FabLab Chemnitz"> | ||
| <submenu _name="Render"/> | ||
| </submenu> |
Owner
There was a problem hiding this comment.
This is not correct. The previous code was correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.