Add ability to set specific BPM #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new box is added to GUI where the BPM multiplier can be provided. If it is provided, it is used to ensure that all the notes and gaps between notes are a multiple of the BPM multiplier. This makes mapping most songs easier, but it might mess up some songs where the notes are weird.
The term multiplier can be confusing as to the role of what it actually does etc. True BPM should be much more easily understandable, especially when contrasted with the term karaoke BPM, hopefully providing a better UX. The only issue is the requirement for the karaoke BPM to be an integer multiple of the true BPM, but that is enforced through an error message.
Sometimes, the first syllable would be moved to the previous line incorrectly. This was because the line break was being placed at the end of the last syllable of each line. However, if due to overlap the next line started before the previous line ended, the line break would end up being placed after the first syllable of the next line. This would result in all the syllables from the next line that start before the line break being placed into the previous line. This happened because the lines are sorted before being saved to disk. It has been fixed by placing the line break at the start of the next line's first syllable instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on #10. A new optional field has been added to GUI (next to the previous (karaoke) BPM field) and a new optional argument has been added to CLI, which allow users to specify the song BPM, i.e. the true BPM of the audio file. If provided, this is used to adjust all the notes such that they are of a length that is an integer multiple of the karaoke BPM, which should make the mapping easier if the OG singer sung the song accurately and precisely. This is because in most songs, to keep the rythm (or is it melod?), notes and breaks are usually evenly spaced. However, this option may cause some incorrect shifting, especially if the inputted BPM is off, or if the singer is off by a fraction of a beat, or if the kara.moe map is a bit off.
To test