Dice stats #105
Merged
Dice stats #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large block of fixes, netrunner
Features 23/12/21
Quick database fix
… implement die operations properly.
…ror, requiring a rework of DiceStats
… to have half implemented keep/drop, onto rerolls and integration
|
#66 is the issue related to this branch and PR |
…enting. added stats help page. made graph nicer (thanks john).
Features 06/01/22
For .sayblah, chunk was correctly consuming "say", but then we got an unknown error when it tried to consume spaces
…ot sure how successful this was, but it should at least be on par.
…s to be expanded in future
finnbar
requested changes
Feb 5, 2022
There was a problem hiding this comment.
First off, this is all very cool and seems to generally hold up to testing - my comments are mainly documentation-related. I also have a few comments from my testing, which I reported to you on Discord but I'm repeating here:
!r 6dreports two different errors, one with "couldn't" and another with "could not". Probably should be standardised, and maybe report one error if possible.- Missing bracket errors (e.g.
!r maximum({d2, d2)and!r maximum({d2, d2}) report the parentWithErrorrather than a more useful child error. Use<??>if you ever want to escape out of theWithError's error. (Maybe comment on<??>with that?) !r 2d(d6)is incorrectly flagged as an error.
Otherwise, looks amazing!
| - monoid-extras-0.6.1 | ||
| - statestack-0.3 | ||
| - diagrams-rasterific-1.4.2.2 | ||
| - git: https://github.com/L0neGamer/haskell-distribution.git |
There was a problem hiding this comment.
as discussed on Discord this is absolutely fine - something to consider when we next update packages
finnbar
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a subcommand to roll that performs statistics on the given expression
the statistics are turned into a graph which is uploaded to discord
This is feature complete, allowing any expression to be turned into a distribution, which can then be analysed and prettified (ie turned into a graph and means and modal values extracted).
Other notable changes are additions to the docs, removal of the parameterised monad in funcinfobase, modifications to the expression parser to try and get better error messages (that failed, but keeping the changes), changes to the command parser to give better errors as well.