Dice variables #133
Merged
Dice variables #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dice-variables
…to dice-variables
|
This PR would end this issue finally: #66 |
finnbar
requested changes
May 2, 2022
There was a problem hiding this comment.
Pleasantly surprised - that was far less difficult to read than I thought it would be. The State monad is doing really wonderful work in simplifying things here. I've added a bunch of comments (most wrt renaming let to var) and found a bug in the stats that needs fixing, but otherwise it seems to work well. Nicely done.
Comment on lines
+110
to
+111
| - set (integer, integer, list) - set the item at the index of the first integer to the value of the second integer in the given list | ||
| - insert (integer, integer, list) - insert the item at the index of the first integer to the value of the second integer in the given list |
There was a problem hiding this comment.
Please mention that these are 0-indexed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dread it
run from it
dice variables are here
including a multitude of changes to the monad stack for dice rolling, parsing dice as a whole, if statements, and let statements (which allow storing of variables as well as lazy evaluation of variables to simulate functions)