Feature/join #45
Closed
Feature/join #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
distributive
suggested changes
Oct 19, 2021
Comment on lines
+47
to
+50
| [r|**Join** | ||
| Repeats the input with some interspersed string or emoji. | ||
|
|
||
| *Usage:* `join :clap: This text will be interspersed with claps!`|] |
There was a problem hiding this comment.
Maybe clarify that the first word will be used as the string.
Comment on lines
+33
to
+40
| clap :: Command | ||
| clap = Command "clap" (parseComm clappytime) | ||
| where | ||
| clappytime :: RestOfInput Text -> Message -> DatabaseDiscord () | ||
| clappytime (ROI t) m = | ||
| sendMessage m $ | ||
| joinify ":clap:" $ | ||
| splitOn " " t |
There was a problem hiding this comment.
You could do clappytime :: Either (Quote Text, RestOfInput Text) RestOfInput Text -> Message -> DatabaseDiscord () to allow users to join with a string containing spaces:
join "x y" a b c d e
x y a x y b x y c x y d x y e
src/Tablebot/Plugins/Join.hs
Outdated
| import Text.RawString.QQ | ||
|
|
||
| joinify :: Text -> [Text] -> Text | ||
| joinify sep text = sep <> " " <> (intercalate (" " <> sep <> " ") text) <> " " <> sep |
There was a problem hiding this comment.
Currently this checks every space:
join x a b c d e
x a x b x x c x x x d x x x x e
|
One more bug:
You could make a new exception ( |
L0neGamer
reviewed
Oct 20, 2021
| -- Stability : experimental | ||
| -- Portability : POSIX | ||
| -- | ||
| -- A command that outputs its input. |
There was a problem hiding this comment.
This description isn't correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a clap and join command, as described in #44