Feat/poll #195
Open
Feat/poll #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
MiniAppleTheApple
force-pushed
the
feat/poll
branch
from
ffa3621
to
1dd8487
Compare
|
SonarCloud Quality Gate failed.
|
Wally5077
requested changes
Sep 3, 2023
| add(it) | ||
| val emojiIndex = EMOJI_UNICODES.indexOf(vote.emoji.name) | ||
| if (emojiIndex >= 0) { | ||
| val optionIndex = voterIdToVotedOptionIndex[vote.userId] |
wow890209
requested changes
Sep 3, 2023
| @@ -33,6 +34,8 @@ private const val OPTION_QUESTION = "question" | |||
|
|
|||
| private const val OPTION_OPTIONS = "options" | |||
|
|
|||
| private const val OPTION_VOTE_LIMIT = "vote-limit" | |||
|
|
|||
| private val EMOJI_UNICODES: Array<String> = arrayOf("0️⃣", "1️⃣", "2️⃣", "3️⃣", "4️⃣", "5️⃣", "6️⃣", "7️⃣", "8️⃣", "9️⃣", "\uD83D\uDD1F") | |||
|
|
|||
| .addRequiredOption(OptionType.INTEGER, OPTION_TIME, "The duration of the poll session") | ||
| .addRequiredOption(OptionType.STRING, OPTION_TIMEUNIT, "(Day | Minute | Second)") | ||
| .addRequiredOption(OptionType.STRING, OPTION_TIMEUNIT, "(Days | Minutes | Seconds)") |
There was a problem hiding this comment.
使用 addChoice()，新增 Days、Minutes、Seconds 三個參數。
| @@ -158,41 +171,58 @@ data class PollingSetting(val time: Long, val timeUnit: TimeUnit, val question: | |||
| } | |||
|
|
|||
| data class Vote(val userId: String, val emoji: EmojiUnion) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact: