Skip to content

fix(controller): incorrect latency of groups #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Itsusinn wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Open

fix(controller): incorrect latency of groups #1007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions clash-lib/src/app/api/handlers/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,21 @@ async fn get_proxy_delay(
) -> impl IntoResponse {
let outbound_manager = state.outbound_manager.clone();
let timeout = Duration::from_millis(q.timeout.into());
let n = proxy.name().to_owned();
let name = proxy.name().to_owned();
let mut headers = HeaderMap::new();
headers.insert(header::CONNECTION, "close".parse().unwrap());

let (actual, overall) = if let Some(group) = proxy.try_as_group_handler() {
let latency_test_url = group.get_latency_test_url();
let proxies = group.get_proxies().await;
Copy link
Copy Markdown
Member

@ibigbug ibigbug Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the current iOS app relies on this behavior somehow, let hold on this and let me double check

Copy link
Copy Markdown
Member Author

@Itsusinn Itsusinn Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


let proxies = match group.get_active_proxy().await {
Some(v) => vec![v],
None => group.get_proxies().await,
};

let results = outbound_manager
.url_test(
&[vec![proxy], proxies].concat(),
&proxies,
&latency_test_url.unwrap_or(q.url),
timeout,
)
Expand All @@ -154,7 +159,7 @@ async fn get_proxy_delay(
return (
StatusCode::BAD_REQUEST,
headers,
format!("get delay for {n} failed with error: {err}"),
format!("get delay for {name} failed with error: {err}"),
)
.into_response();
}
Expand All @@ -169,7 +174,7 @@ async fn get_proxy_delay(
return (
StatusCode::BAD_REQUEST,
headers,
format!("get delay for {n} failed with error: {err}"),
format!("get delay for {name} failed with error: {err}"),
)
.into_response();
}
Expand Down
Loading