Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic versioning substitution and plugin requirement #74

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Feb 5, 2025

Description

This PR fixes dynamic versioning substitution and adds a plugin requirement (new for Poetry >= 2.0). This comes as a result of @jenna-tomkinson noticing that when the package is installed it doesn't include the correct version when using cytodataframe.__version__ (normally replaced during package builds).

In addition, we also update linting checks to automatically update in order to make sure the poetry checks pass (and other linters are checked for updates alongside changes to the project).

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from jenna-tomkinson February 5, 2025 20:52
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this fix! 🎉

@d33bs
Copy link
Member Author

d33bs commented Feb 5, 2025

Thanks @jenna-tomkinson !

@d33bs d33bs merged commit 55022ce into WayScience:main Feb 5, 2025
9 checks passed
@d33bs d33bs deleted the fix-package-versioning branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants