-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cropped image-based output for .tiff
files with SCDataFrame
#44
Conversation
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this PR since I don't see any major issues or bugs. I left a few comments for you to address, let me know if you have any questions. LGTM!
Co-authored-by: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Thanks Jenna for your review! I've addressed all comments and will now merge this in. |
Description
This PR updates
SCDataFrame
to enable cropped image-based output for.tiff
files in order to better visualize single-cell information in context with quality control aspects already implemented withincoSMicQC
. Along the journey towards this work I found that we needed to extendpandas.DataFrame
throughSCDataFrame
in order to effectively achieve the related outcomes. This in turn caused many more changes to theSCDataFrame
class which may not look necessary but ultimately enable the use of the class within Jupyter contexts (while retaining existing functionality).I've added an example notebook to help demonstrate the capabilities found within this PR. Within this example notebook I also implement the existing
label_outliers
function and show the plots to help ensure all existing functionality was not impacted by the new additions found here.The changes here strive towards #33 by addressing #40 (we still will need to find segmentation data and add this to display).
Closes #40
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.