Exit with status 0 when EOF on stdin is encountered. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced non-zero exit code with zero exit code when EOF is read from stdin. EOF occurs when the server process closes its log file, and should not be an error condition.
Exit 0 on EOF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cronolog has forever returned a status code of 3 when it encounters an EOF on stdin; however, EOF is a normal condition when the upstream process closes its log file or exits and should not be treated as abnormal by cronolog. A non-zero status impairs the use of cronolog in pipes by making it impossible to determine if the pipeline was successful. This pull request changes the exit code to 0 when EOF is encountered.