Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "A bunch of useful changes" #18

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Revert "A bunch of useful changes" #18

merged 1 commit into from
Sep 26, 2024

Conversation

LaeDev
Copy link
Member

@LaeDev LaeDev commented Sep 26, 2024

Reverts #17

Needs more change. will be merge after this.

@LaeDev LaeDev merged commit 6c4fc5a into 1.20.1 Sep 26, 2024
1 of 3 checks passed
@LaeDev LaeDev deleted the revert-17-1.20.1 branch September 26, 2024 21:17
@qualk
Copy link
Contributor

qualk commented Sep 26, 2024

What kind of changes? I'd be happy to work on it further, I wanted to add the Korean annotations back and remove the i18n have have it on a different branch.

@LaeDev
Copy link
Member Author

LaeDev commented Sep 26, 2024

I changed Java Distro, and I also merged it wrong, I didn't mean to merge everything, and I also didn't mean to ignore your pull request. I'll do another revert if you want, and then if you want to make a request similar to this, I'll accept it immediately.

@LaeDev LaeDev self-assigned this Sep 26, 2024
@LaeDev LaeDev added the invalid This doesn't seem right label Sep 26, 2024
@qualk
Copy link
Contributor

qualk commented Oct 1, 2024

I'm going to scrap this PR and make a series of new ones, for each change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants