Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Iris compatibility #22

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

qualk
Copy link
Contributor

@qualk qualk commented Oct 4, 2024

Removes legacy Iris compatibility, adds hard failure (should it be a soft failure?)

@qualk
Copy link
Contributor Author

qualk commented Oct 4, 2024

In commit 3587e86, gradlew was made non-executable (755 to 644), resulting in the GitHub actions failing. Can I resolve that in this PR, or should I make another PR?

@LaeDev
Copy link
Member

LaeDev commented Oct 8, 2024

In commit 3587e86, gradlew was made non-executable (755 to 644), resulting in the GitHub actions failing. Can I resolve that in this PR, or should I make another PR?

Do it in other PR :)

@qualk
Copy link
Contributor Author

qualk commented Oct 8, 2024

In commit 3587e86, gradlew was made non-executable (755 to 644), resulting in the GitHub actions failing. Can I resolve that in this PR, or should I make another PR?

Do it in other PR :)

#23 :)

src/main/resources/fabric.mod.json Show resolved Hide resolved
@LaeDev LaeDev merged commit fad39a9 into We-Cant-Coding:1.20.1 Oct 26, 2024
1 check failed
@LaeDev
Copy link
Member

LaeDev commented Oct 26, 2024

i didnt checked the code lmao is it able to build?

@qualk
Copy link
Contributor Author

qualk commented Oct 26, 2024

Doesn't seem like it, even though it built for me. I think it's because the Modrinth maven is bit weird at times. Can you revert the PR?

@LaeDev
Copy link
Member

LaeDev commented Oct 26, 2024

Sure. Hold on a sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants