Merge pull request #139 from WeTransfer/revert-disabling-throttoling

Enable a rate limiter
WeTransfer · Sep 21, 2017 · 7c30bdb · 7c30bdb
2 parents 52e5ec9 + 84da6c0
commit 7c30bdb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/lib/xperiments/web/controllers/assigner_controller.ex b/lib/xperiments/web/controllers/assigner_controller.ex
@@ -2,7 +2,7 @@ defmodule Xperiments.Web.AssignerController do
   use Xperiments.Web, :controller
   alias Xperiments.{Repo, Experiment}
 
-  # plug Xperiments.Plug.RateLimit, max_requests: 5, interval_seconds: 60
+  plug Xperiments.Plug.RateLimit, max_requests: 5, interval_seconds: 60
   plug :auth_request when action in [:example]
 
   def experiments(conn, params) do

diff --git a/test/controllers/assigner_controller_test.exs b/test/controllers/assigner_controller_test.exs
@@ -98,16 +98,16 @@ defmodule Xperiments.AssignerControllerTest do
       assert db_exp.statistics.variants_impression == %{hd(context.exp.variants).id => 4}
     end
 
-    # test "requests are throttled", context do
-    #   for _i <- 0..4 do
-    #     post(context.conn, "#{@api_path}/experiments/events", %{event: "impression", payload: context.call_payload})
-    #     |> json_response(200)
-    #   end
-    #   body =
-    #     post(context.conn, "#{@api_path}/experiments/events", %{event: "impression", payload: context.call_payload})
-    #   |> json_response(403)
-    #   assert body == %{"error" => "Rate limit exceeded"}
-    # end
+    test "requests are throttled", context do
+      for _i <- 0..4 do
+        post(context.conn, "#{@api_path}/experiments/events", %{event: "impression", payload: context.call_payload})
+        |> json_response(200)
+      end
+      body =
+        post(context.conn, "#{@api_path}/experiments/events", %{event: "impression", payload: context.call_payload})
+      |> json_response(403)
+      assert body == %{"error" => "Rate limit exceeded"}
+    end
   end
 
   describe "Rules/Segments logic" do