Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue Demo: update deps, make passkeys zero weight in validation #338

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Sep 2, 2024

Motivation and Context

This PR to make passkeys zero weight in validation.

Jira Link:

Description

make passkeys zero weight in validation to match auth-service

How has this been tested?

Screenshots (if appropriate):

Screenshot 2024-09-02 at 23 21 10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 94376b3 into master Sep 3, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/vue-demo-make-passkeys-zero-weight branch September 3, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants