Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ed25519 to use import flow by default #163

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

himanshuchawla009
Copy link
Contributor

  • So far we generate ed25519 mpc keys using dkg but that makes it impossible to export the seed.
  • To tackle this issue this PR changes the default ed25519 login flow to use import key flow such that seed is generated on frontend and thn same seed can be exported.
  • Applications who still want to use dkg for ed25519 with the downside of key exportablity can still use it by setting useDkg flag to false in constructor explicitlu.

@himanshuchawla009 himanshuchawla009 marked this pull request as draft August 22, 2024 09:46
@himanshuchawla009 himanshuchawla009 marked this pull request as ready for review August 22, 2024 10:20
Copy link
Contributor

@matthiasgeihs matthiasgeihs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some comments. much of it is code style and i'll add a commit to clean that up.

note my other comment on the default value of the new useDKG option.

src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/interfaces.ts Outdated Show resolved Hide resolved
src/mpcCoreKit.ts Outdated Show resolved Hide resolved
src/mpcCoreKit.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@matthiasgeihs matthiasgeihs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment on usage of scalarBNToBufferSEC1, see above. otherwise looks good i think

@himanshuchawla009 himanshuchawla009 merged commit 15a7855 into master Aug 22, 2024
1 check passed
@himanshuchawla009 himanshuchawla009 deleted the feat/ed25519-default-import branch August 22, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants