-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ed25519 to use import flow by default #163
Conversation
himanshuchawla009
commented
Aug 22, 2024
- So far we generate ed25519 mpc keys using dkg but that makes it impossible to export the seed.
- To tackle this issue this PR changes the default ed25519 login flow to use import key flow such that seed is generated on frontend and thn same seed can be exported.
- Applications who still want to use dkg for ed25519 with the downside of key exportablity can still use it by setting useDkg flag to false in constructor explicitlu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some comments. much of it is code style and i'll add a commit to clean that up.
note my other comment on the default value of the new useDKG
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor comment on usage of scalarBNToBufferSEC1
, see above. otherwise looks good i think