Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use viem fully for managing typed signing #1996

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Oct 23, 2024

Motivation and Context

Fixed Issue #1994
Jira Link:

Description

Fixed Issue #1994
Allow viem to manage the DAG verification and allow non-root to be primaryType

How has this been tested?

Tested with demo app

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Copy link

@tuna1207 tuna1207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 70143f4 into master Oct 29, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/viem-signing branch October 29, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants