Skip to content

Unified Packages #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 11, 2025
Merged

Unified Packages #2059

merged 15 commits into from
Feb 11, 2025

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Jan 22, 2025 •
edited
Loading

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/PD-4270

Description

Reduce the number of packages to no-modal and modal.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@arch1995 arch1995 self-assigned this Jan 22, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 9:59am

@arch1995
Merge branch 'feat/one-package' of github.com:Web3Auth/web3auth-web; …
371b86f 
…branch 'master' of github.com:Web3Auth/Web3Auth into feat/one-package
chaitanyapotti
chaitanyapotti reviewed Feb 11, 2025
View reviewed changes
chaitanyapotti
chaitanyapotti approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit ad61787 into master Feb 11, 2025
3 of 4 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/one-package branch February 11, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

@arch1995 arch1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arch1995 @chaitanyapotti