feat: implement asset-based discount system for platform fees#138
Open
vicajohn wants to merge 1 commit intoWeb3Novalabs:mainfrom
Open
feat: implement asset-based discount system for platform fees#138vicajohn wants to merge 1 commit intoWeb3Novalabs:mainfrom
vicajohn wants to merge 1 commit intoWeb3Novalabs:mainfrom
Conversation
Author
|
please review |
- Add storage keys for asset discounts and platform fee percentage - Implement admin functions to set/get platform fees and asset discounts - Modify contribute function to apply discounts based on asset type - Add comprehensive test suite with 10 test cases - Include detailed documentation and usage guides Features: - Configurable base platform fee (in basis points) - Token-specific discounts (e.g., 50% off for NEVO token) - Automatic fee calculation with discount applied - Separate tracking of platform fees - Admin-only access with validation - Event emissions for transparency Test Coverage: - Fee and discount configuration - Fee calculations with various discount levels - Multiple assets with different discounts - Edge cases (0% fee, 100% discount) - Input validation Documentation: - Technical implementation details - User and developer guides - Visual flow diagrams - API reference and examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
Features:
Test Coverage:
Documentation: