Implementation and test suite for resume_throw_ref #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not tested.
(Still not right though)
fgmccabe
requested review from
dhil and
tlively
and removed request for
tlively
tlively
reviewed
Oct 17, 2025
rossberg
reviewed
Oct 18, 2025
remove extra space Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
mark pattern variable as not used Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Thomas Lively <tlively@google.com>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
and add some comments to tests.
tlively
approved these changes
Oct 20, 2025
dhil
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some basic tests for resume_throw_ref
(Factored out in a separate file)
Implemented in reference interpreter